Skip to content

New user roles #387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 1, 2019
Merged

New user roles #387

merged 7 commits into from
Oct 1, 2019

Conversation

maxceem
Copy link
Contributor

@maxceem maxceem commented Oct 1, 2019

Project Service support of new roles as per appirio-tech/connect-app#3298

@maxceem maxceem requested a review from vikasrohit October 1, 2019 05:17
Copy link

@vikasrohit vikasrohit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to confirm @maxceem, when a user with new roles in trying to join a project using Join button, they would join as standard Manager role, not with their specific role, right? (Ideally we want them to join project with their specific user role only)
Also, when some else is inviting a user with new roles or editing roles of such users, they would be able to assign these new roles to their specific roles along with the regular Manager role, right? (Ideally we want them only to be able to assume the user role they have)

@maxceem
Copy link
Contributor Author

maxceem commented Oct 1, 2019

Just to confirm @maxceem, when a user with new roles in trying to join a project using Join button, they would join as standard Manager role, not with their specific role, right? (Ideally we want them to join project with their specific user role only)

Right. So far like that.

  • If a user with a new user role like “Business Development Representative”, “Presales”, “Account Executive” click Join button, he will join as “accound_manager”

  • If a user with a new manager roles like “Program Manager”, “Solution Architect”, “Project Manager” clicks "Join" button, he will join as "manager" by default. Though such a user will see a dialog where he can choose more specific role:

    image

Also, when some else is inviting a user with new roles or editing roles of such users, they would be able to assign these new roles to their specific roles along with the regular Manager role, right? (Ideally we want them only to be able to assume the user role they have)

Right. So far we give users a freedom to assign any role of the same level. Like “Solution Architect” can become a "Manager" inside project.

@vikasrohit vikasrohit merged commit e2ad1f7 into dev Oct 1, 2019
@vikasrohit
Copy link

One more observation @maxceem when a Connect Manager is trying to join the project, as Program Manager, using the Join button, it is erroring out saying that user needs Program Manager role to join project in the same capacity. Just wanted to know, if you are also on the same page for this.

@maxceem
Copy link
Contributor Author

maxceem commented Oct 1, 2019

One more observation @maxceem when a Connect Manager is trying to join the project, as Program Manager, using the Join button, it is erroring out saying that user needs Program Manager role to join project in the same capacity. Just wanted to know, if you are also on the same page for this.

@vikasrohit thanks for pointing that out. I've noticed, that there is some inconsistency in how we let users invite any user with any role, while when users join the project themselves, the rules are more strict.

I've create a new issue to track what improvements we can do for the new user roles appirio-tech/connect-app#3345. Most of them can be done client-side only. While server-side issues could be releases later, as they are not blocking, server-side changes mostly only need to restrict user actions on the backend.

@vikasrohit
Copy link

Okay, Thanks for logging the issue. We can move the front end changes via hotfixes.

@eisbilir eisbilir deleted the feature/new-roles branch November 9, 2023 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants